Adding DscTestsPresent rule #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change property display name to be the same as property name
Merge BugFixes to Master
Merge features from Development to Master
This is required for publishing to PSGallery.
Add wild card support to Get-ScriptAnalyzerRule
…riableFixBranch Fix typo in file name for AvoidUninitializedVariable.cs
…tem.Management.Automation.EngineIntrinsics
According to cmdlet design guideline: we recommend omitting the cmdlet noun from parameter names since it's redundant (i.e. Get-ScriptAnalyzerRule -RuleName).
…itializedVariableFixBranch AvoidUninitialized Variable Rule must recognize built-in variable $ExecutionContext
…tructions Updating installation instructions
Change the import module name and .psd1 file to ScriptAnalyzer to match the VS solution name. That way we can solve the confusion of binplace and import-module.
Update the module name back to PSScriptAnalyzer name.
We need to have Microsoft Corp in these fields.
Updated Author, CompanyName and Copyright properties
Only Trigger PSProvideVerboseMessage in Advanced Scripts or Functions
Revert "Only Trigger PSProvideVerboseMessage in Advanced Scripts or F…
…00-BugFixes Revert "Revert "Only Trigger PSProvideVerboseMessage in Advanced Scri…
Added quotes for code
…ocumentationBranch Avoid wmi cmdlet rule documentation
…01-revert-100-BugFixes Revert the pull request
Take Bug fixes to Master
| } | ||
|
|
||
| It "has the correct description message" { | ||
| $violations[0].Message | Should Match $violationMessage |
There was a problem hiding this comment.
Use 'Should Be' when comparing strings. Match is for regex
…ntati Added customized rule documentation
…iptAnalyzer into DscTestsPresentRule
|
using Be instead of Match |
|
Sign-off from me |
Regenerated strings.designer due to change in rule name (WMIObject to WMICmdlet)
|
Looks good to me too. |
… into DscTestsPresentRule
|
Thanks Karol! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #97